Review Request 115770: fix the expression visitor

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115770/#review50101
-----------------------------------------------------------

Ship it!


one small nitpick - otherwise looks good. Sven, if you want to commit it, you could apply the change locally as well and then commit it.

Thanks again for the contributions here Matija!


duchain/usebuilder.cpp
<https://git.reviewboard.kde.org/r/115770/#comment35199>

    add a newline in front of the init list and indent it please
    
    UseBuilder::....
      : ExpressionVisitor( editor )
    {
      ...
    }


- Milian Wolff


On Feb. 16, 2014, 2:37 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115770/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 2:37 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> Expression visitor should not inherit from the context builder
> and should not visit the whole compilation unit.
> 
> This commit fixes the problem with variable colors.
> 
> 
> Diffs
> -----
> 
>   duchain/abstractexpressionvisitor.h a590096 
>   duchain/expressionvisitor.h 652a2cd 
>   duchain/expressionvisitor.cpp 95b660f 
>   duchain/usebuilder.h 48e591d 
>   duchain/usebuilder.cpp 527e813 
> 
> Diff: https://git.reviewboard.kde.org/r/115770/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140217/e67ef169/attachment-0001.html>