Review Request 115722: Import fixits from Clang

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115722/#review50026
-----------------------------------------------------------



duchain/clangproblem.h
<https://git.reviewboard.kde.org/r/115722/#comment35126>

    then we'll have to serialize it as well which is... not so easy ;-) 
    
    I'd rather put the data into a custom problem and from that create a solution-assistant. setting the ptr is not good for serialization



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment35127>

    col -> column



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115722/#comment35128>

    return a KSharedPtr<ClangProblem> here please to ensure its not leaked accidentally.
    
    You can then later use ProblemPointer::staticCast(foo);
    
    or better yet, you remove the "setSolutionAssistant" and return polymorphic problems here which know how to fix themselves - then you can just return a ProblemPointer here



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115722/#comment35129>

    one will have to investigate that for other purposes (i.e. to get the default parameter values). I think it could be done via tokenizing a range and then stringifying the tokens.


- Milian Wolff


On Feb. 13, 2014, 1:02 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115722/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 1:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Import fixits from Clang
> 
> REVIEW: 115722
> 
> 
> Diffs
> -----
> 
>   tests/test_problems.h 7df526ec44dd02c5e6e9e5eb42c560fda663f9f7 
>   duchain/parsesession.cpp 265e09975de60f65040dd74b70235baf32f331ab 
>   duchain/clangproblem.h PRE-CREATION 
>   duchain/clangproblem.cpp PRE-CREATION 
>   duchain/CMakeLists.txt 7ab2e8adde7eb55c5d029d13151729034d889fb7 
>   tests/test_problems.cpp e3f42d61223df86551951c5533fb49477c8bf016 
> 
> Diff: https://git.reviewboard.kde.org/r/115722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140217/4ac39824/attachment.html>