Review Request 115771: fix the unit test for use builder

[Sven Brauch]

> On Feb. 16, 2014, 10:33 a.m., Sven Brauch wrote:
> > Can you explain why you want to change this? It feels like it makes the test weaker for no real reason, since you won't catch stray uses somewhere outside of what you expect.
> 
> Matija Skala wrote:
>     Previously the uses were found even if they were in the top context instead of the function. The change makes sure that they are found in the function context.

I'd instead should find uses everywhere and then verify that its context is indeed the function context. That tests for more possible errors.
But this approach is okay too, I'll submit this and if you want you can change it later. Thanks!


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115771/#review49897
-----------------------------------------------------------


On Feb. 16, 2014, 2:10 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115771/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 2:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> it should look for uses only in the first method
> 
> 
> Diffs
> -----
> 
>   duchain/tests/javaduchaintest.cpp cf8fd37 
> 
> Diff: https://git.reviewboard.kde.org/r/115771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140216/bab5d589/attachment.html>