Review Request 115771: fix the unit test for use builder

Sven Brauch svenbrauch at googlemail.com
Sun Feb 16 10:33:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115771/#review49897
-----------------------------------------------------------


Can you explain why you want to change this? It feels like it makes the test weaker for no real reason, since you won't catch stray uses somewhere outside of what you expect.

- Sven Brauch


On Feb. 16, 2014, 2:10 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115771/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 2:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> it should look for uses only in the first method
> 
> 
> Diffs
> -----
> 
>   duchain/tests/javaduchaintest.cpp cf8fd37 
> 
> Diff: https://git.reviewboard.kde.org/r/115771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140216/a86fea28/attachment.html>


More information about the KDevelop-devel mailing list