Review Request 115770: fix the expression visitor

[Matija Skala]

> On Feb. 16, 2014, 3:17 a.m., Sven Brauch wrote:
> > duchain/abstractexpressionvisitor.h, line 62
> > <https://git.reviewboard.kde.org/r/115770/diff/1/?file=244302#file244302line62>
> >
> >     why this->?
> 
> Matija Skala wrote:
>     to use overrided visitNode()

... and if i writed just visitNode(ast), the compiler will complain because this is a template


- Matija


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115770/#review49891
-----------------------------------------------------------


On Feb. 16, 2014, 3:37 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115770/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 3:37 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> Expression visitor should not inherit from the context builder
> and should not visit the whole compilation unit.
> 
> This commit fixes the problem with variable colors.
> 
> 
> Diffs
> -----
> 
>   duchain/abstractexpressionvisitor.h a590096 
>   duchain/expressionvisitor.h 652a2cd 
>   duchain/expressionvisitor.cpp 95b660f 
>   duchain/usebuilder.h 48e591d 
>   duchain/usebuilder.cpp 527e813 
> 
> Diff: https://git.reviewboard.kde.org/r/115770/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140216/f4b36777/attachment.html>