Review Request 115770: fix the expression visitor

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115770/#review49891
-----------------------------------------------------------

Ship it!


For me, this makes more sense than the previous solution.


duchain/abstractexpressionvisitor.h
<https://git.reviewboard.kde.org/r/115770/#comment35058>

    this method probably shouldn't be called parse, but visit or so ... 



duchain/abstractexpressionvisitor.h
<https://git.reviewboard.kde.org/r/115770/#comment35056>

    why this->?



duchain/expressionvisitor.cpp
<https://git.reviewboard.kde.org/r/115770/#comment35057>

    use auto to avoid this horrible type ;)
    also, why the __?


- Sven Brauch


On Feb. 16, 2014, 1:54 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115770/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 1:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> Expression visitor should not inherit from the context builder
> and should not visit the whole compilation unit.
> 
> This commit fixes the problem with variable colors.
> 
> 
> Diffs
> -----
> 
>   duchain/usebuilder.h 48e591d 
>   duchain/usebuilder.cpp 527e813 
>   duchain/expressionvisitor.cpp 95b660f 
>   duchain/expressionvisitor.h 652a2cd 
>   duchain/abstractexpressionvisitor.h a590096 
> 
> Diff: https://git.reviewboard.kde.org/r/115770/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140216/c6620884/attachment.html>