Review Request 115706: Refactor / Rename variables and functions

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115706/#review49771
-----------------------------------------------------------


So, some small styling issues are left but please see this as nitpicking only. Probably these issues are also in the old code which you copied, I just want to make new code more beautiful :)

Cheers


clanglanguagesupport.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34995>

    move this to the other <language/..> includes below



clanglanguagesupport.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34994>

    please use upper-case includes and add an empty line before this block
    
    #include <KAction>
    #include <KActionCollection>



codegen/simplerefactoring.h
<https://git.reviewboard.kde.org/r/115706/#comment34996>

    please use your name and the current year for copyright here and in the other files you added



codegen/simplerefactoring.h
<https://git.reviewboard.kde.org/r/115706/#comment34990>

    ftr: our codying style puts the braces of functions and classes on their own line



codegen/simplerefactoring.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34992>

    too many newlines here and below



codegen/simplerefactoring.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34991>

    brace, and remove the KDevelop:: identifiers (you use the namespace after all)



codegen/simplerefactoring.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34993>

    just DUChainReadLocker lock;


- Milian Wolff


On Feb. 13, 2014, 8:20 p.m., Michael Ferris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115706/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 8:20 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Allows to rename functions and variables from context menu and Code/Rename menu. Currently have some bugs with renaming classes.
> 
> 
> Diffs
> -----
> 
>   kdevclangsupport.rc PRE-CREATION 
>   CMakeLists.txt fbf74a7 
>   clanglanguagesupport.h 65a1407 
>   clanglanguagesupport.cpp a15fe0a 
>   codegen/CMakeLists.txt PRE-CREATION 
>   codegen/codegenexport.h PRE-CREATION 
>   codegen/simplerefactoring.h PRE-CREATION 
>   codegen/simplerefactoring.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115706/diff/
> 
> 
> Testing
> -------
> 
> Rename global variable across multiple files.
> Rename local variables and functions.
> 
> 
> Thanks,
> 
> Michael Ferris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140214/e759128c/attachment.html>