Review Request 115706: Refactor / Rename variables and functions

Milian Wolff mail at milianw.de
Thu Feb 13 16:41:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115706/#review49716
-----------------------------------------------------------


looks good - just remove the commented-out code and don't revert previous changes please!

thanks


clangparsejob.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34973>

    this is an unrelated changeset, probably the diff should be updated? i.e. git puill --rebase or similar?



codegen/simplerefactoring.h
<https://git.reviewboard.kde.org/r/115706/#comment34972>

    remove this blob



codegen/simplerefactoring.cpp
<https://git.reviewboard.kde.org/r/115706/#comment34971>

    remove this blob


- Milian Wolff


On Feb. 12, 2014, 9:41 p.m., Michael Ferris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115706/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 9:41 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Allows to rename functions and variables from context menu and Code/Rename menu. Currently have some bugs with renaming classes.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fbf74a7 
>   clanglanguagesupport.h 65a1407 
>   clanglanguagesupport.cpp a15fe0a 
>   clangparsejob.cpp ba0d3db 
>   codegen/CMakeLists.txt PRE-CREATION 
>   codegen/codegenexport.h PRE-CREATION 
>   codegen/simplerefactoring.h PRE-CREATION 
>   codegen/simplerefactoring.cpp PRE-CREATION 
>   kdevclangsupport.desktop.cmake e9ac541 
>   kdevclangsupport.rc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115706/diff/
> 
> 
> Testing
> -------
> 
> Rename global variable across multiple files.
> Rename local variables and functions.
> 
> 
> Thanks,
> 
> Michael Ferris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140213/99a12d46/attachment.html>


More information about the KDevelop-devel mailing list