Review Request 115637: add UseExpressionVisitor
Matija Skala
mskala at gmx.com
Tue Feb 11 12:23:58 UTC 2014
> On Feb. 11, 2014, 11:25 a.m., Milian Wolff wrote:
> > duchain/usebuilder.h, line 47
> > <https://git.reviewboard.kde.org/r/115637/diff/1/?file=243140#file243140line47>
> >
> > not sure if someone already fixed that for kdev-java, but we can now use C++11 in all of kdev* code base.
> >
> > So this should be marked as override. Also, make sure that the top-level CMakeLists.txt enables C++11.
i'm afraid i didn't understand. what should be marked as override here?
- Matija
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115637/#review49523
-----------------------------------------------------------
On Feb. 11, 2014, 1:16 p.m., Matija Skala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115637/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 1:16 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-java
>
>
> Description
> -------
>
> so that uses of variables are detected. The startVisiting() function might seem a bit hacky, but it works and produces no new issues. I will improve it in one of the future commits.
>
>
> Diffs
> -----
>
> duchain/usebuilder.h 2c13dff
> duchain/usebuilder.cpp 513c03c
>
> Diff: https://git.reviewboard.kde.org/r/115637/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matija Skala
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140211/96f33142/attachment.html>
More information about the KDevelop-devel
mailing list