Review Request 115637: add UseExpressionVisitor

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115637/#review49523
-----------------------------------------------------------

Ship it!


A few minor nitpicks, then go for it!

Just a hint: This approach is a good to get things going in a first approximation. But it will probably fail as soon as you have nested contexts, no? I.e. when you start visiting, you "inject" the top context but where are the sub contexts set as the current context from which to search for declarations? Anyhow - this is something you should investigate later then and we can come up with a way to fix it then.

Thanks for working on this!


duchain/usebuilder.h
<https://git.reviewboard.kde.org/r/115637/#comment34921>

    not sure if someone already fixed that for kdev-java, but we can now use C++11 in all of kdev* code base.
    
    So this should be marked as override. Also, make sure that the top-level CMakeLists.txt enables C++11.



duchain/usebuilder.cpp
<https://git.reviewboard.kde.org/r/115637/#comment34920>

    override



duchain/usebuilder.cpp
<https://git.reviewboard.kde.org/r/115637/#comment34922>

    override



duchain/usebuilder.cpp
<https://git.reviewboard.kde.org/r/115637/#comment34923>

    why this comment? why is it not delegated?


- Milian Wolff


On Feb. 11, 2014, 3:33 a.m., Matija Skala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115637/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 3:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-java
> 
> 
> Description
> -------
> 
> so that uses of variables are detected. The startVisiting() function might seem a bit hacky, but it works and produces no new issues. I will improve it in one of the future commits.
> 
> 
> Diffs
> -----
> 
>   duchain/usebuilder.h 2c13dff 
>   duchain/usebuilder.cpp 513c03c 
> 
> Diff: https://git.reviewboard.kde.org/r/115637/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matija Skala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140211/3d0759f1/attachment-0001.html>