Review Request 115647: Manpage: Normalize look of documentation

Milian Wolff mail at milianw.de
Tue Feb 11 10:18:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115647/#review49522
-----------------------------------------------------------



documentation/manpage/manpagedocumentation.css
<https://git.reviewboard.kde.org/r/115647/#comment34919>

    for the future: it's pretty common in CSS to use 0 without a unit.
    
    Also, these two statements could be replaced by "display: none;" which achieves the same result in a more common way.


- Milian Wolff


On Feb. 11, 2014, 9:03 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115647/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 9:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Manpage: Normalize look of documentation
> 
> Apply custom style-sheet in order to save horizontal screen space and
> remove the (broken) top banner
> 
> 
> Diffs
> -----
> 
>   documentation/manpage/manpagedocumentation.css PRE-CREATION 
>   documentation/manpage/CMakeLists.txt f50a0f2b271e926d4e97e2b23dc6bad82b5cd652 
>   documentation/manpage/manpagedocumentation.cpp a792cc73679c816d51a8bccd5da172dfe6ad8cba 
> 
> Diff: https://git.reviewboard.kde.org/r/115647/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Left: Old look, right: New look
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/11/f2f7bf46-1640-48ee-ae6a-378ad1321208__kdevelop-manpage-oldvsnew.png
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140211/fa0b1c1e/attachment.html>


More information about the KDevelop-devel mailing list