Review Request 115600: Added buttons to jump to next/prev outputmark in an outputwidget

[Todd Nowacki]

> On Feb. 9, 2014, 7:06 p.m., Sven Brauch wrote:
> > Yup that looks good now ( given that it works ;)
> > 
> > ... except for the whitespace errors. A good way to remove them is to start "git gui", select "amend last commit" and then simply click the two lines and select "unstage", then commit the result.
> > 
> > Do you have commit access, or shall I submit this?

I'll revert the white space errors. And I need to set up commit access anyway for my Open Academy project, so I'll submit it later. 


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115600/#review49376
-----------------------------------------------------------


On Feb. 9, 2014, 6:57 p.m., Todd Nowacki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115600/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2014, 6:57 p.m.)
> 
> 
> Review request for KDevelop and Alexander Dymo.
> 
> 
> Bugs: 330206
>     http://bugs.kde.org/show_bug.cgi?id=330206
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is in response to https://bugs.kde.org/show_bug.cgi?id=330206
> 
> I added buttons to all output widgets instead of the one for the build tool view; we can easily restrict this to a certain type of view if we want to. 
> 
> The only problem with the buttons is that they are enabled even if there are no outputmarks to jump to. At the time of creating this diff, I did not see an easy way to find the number of outputmark.
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/outputwidget.h 98cd94988b9a278b6509702c18956e580226ffc9 
>   plugins/standardoutputview/outputwidget.cpp 7f248c4924ba4c2129f1f1fa7b28d7fd6ab6a7ed 
>   plugins/standardoutputview/standardoutputview.cpp 60379a9a909a27b1c611344ad47476b84a91141a 
> 
> Diff: https://git.reviewboard.kde.org/r/115600/diff/
> 
> 
> Testing
> -------
> 
> The buttons work for the build window.
> 
> 
> Thanks,
> 
> Todd Nowacki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140209/5a41c426/attachment.html>