Review Request 113815: Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths"

[Meenakshi Khorana]

> On Jan. 30, 2014, 4:36 p.m., Kevin Funk wrote:
> > languages/cpp/codegen/customincpath.h, line 13
> > <https://git.reviewboard.kde.org/r/113815/diff/2/?file=234195#file234195line13>
> >
> >     Please rename the class to CustomIncludePaths, and the file to customincludepaths.h. That way it is consistent to the UI file's class name.
> >     
> >     Don't forget to fix include guards as well.
> >     
> >     More: I'd prefer to have setters and getters for the attributes of Ui::CustomIncludePaths instead of making that public.
> >     
> >     E.g. add 'void setStorageDirectory(const KUrl&)', 'KUrl storageDirectory() const' etc. pp. You should end up with 4 setters and 4 getters.
> >     
> >     Additional note: Class members are written in the following order: First: public members, then protected members, then private members.

Added two getter functions. One for getting url and another for getting text.


- Meenakshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113815/#review48641
-----------------------------------------------------------


On Jan. 30, 2014, 5:25 p.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113815/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 221792
>     http://bugs.kde.org/show_bug.cgi?id=221792
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Patch for Bug 221792 - integrate folder browser in "Setup Custom Include Paths" 
> 
> Integrated a folder browser to add custom include paths. User can add custom include paths on a button click and can view the added paths in plain text edit box.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 66030be 
>   languages/cpp/codegen/customincpath.h PRE-CREATION 
>   languages/cpp/codegen/customincpath.cpp PRE-CREATION 
>   languages/cpp/codegen/ui/custom_include_paths.ui 1a7c1ed 
>   languages/cpp/codegen/unresolvedincludeassistant.cpp 93a72d3 
>   languages/cpp/tests/CMakeLists.txt 9ce3c7b 
> 
> Diff: https://git.reviewboard.kde.org/r/113815/diff/
> 
> 
> Testing
> -------
> 
> Compiled and Tested successfully on local machine.
> 
> 
> File Attachments
> ----------------
> 
> Added open file dialog to custom include path
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/34ab7f7c-7aca-4c16-ab3f-add513c22f56__folder_browser_1.jpg
> Folder browser for selecting include paths
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/29a48901-93ee-40e7-9455-94acb648025e__folder_browser_2.jpg
> Added include paths will be visible to user in text edit
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/11/12/bf9fb89b-8e6e-49f8-b2b5-d865ded209b7__folder_browser_3.jpg
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140207/5c5a2c27/attachment.html>