Review Request 115506: A fix so CMake errors link to the proper file.

[Kevin Funk]

> On Feb. 6, 2014, 9:35 p.m., Morten Volden wrote:
> > Okay, I've had a chance to look at bit closer on the patch.
> > 
> > The assumption that source directory is the parent dir of the build directory is, I'll admit, pretty lame. So I'm pretty pleased that something is being done about it.
> > 
> > However, looking at the patch a little more closely I'm not sure I'm too keen on having the output filtering strategy know about projects.
> > 
> > First of all I'm not sure that the patch will solve bug #321982 in all cases. The issue specifies that during compilation the following line occurs:
> > 
> > CMake Error at foo/CMakeLists.txt:435 (ADD_LIBRARY):
> > 
> > If multiple projects are open with a subpath named 'foo' wouldn't it be random which CMakeLists.txt the user is forwarded to?
> > 
> > I think I would prefer it if the project path is inferred at the time the job is created and then passed to the CompilerFilter. That way it would also be easier to test the feature.
> > 
> > 
> > 
> > 
> >

By the way, I made some attempts at the CMake devel list in order to fix the root issue - CMake not printing absolute paths - a while ago: http://public.kitware.com/pipermail/cmake/2013-July/055361.html. Unfortunately no one replied at that point. I'll try to get this discussion running again.

Regarding the code: It's rather unfortunate that we have to put so much logic into the filter strategies just make this work with CMake. :/


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115506/#review49152
-----------------------------------------------------------


On Feb. 5, 2014, 10:37 p.m., Todd Nowacki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115506/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 321982
>     http://bugs.kde.org/show_bug.cgi?id=321982
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Before, it was assumed that the build directory was an immediate child of the source directory.
> 
> Now, we iterate through each project (via the project controller) to find a project with a matching build directory and grab the source directory from that project. 
> 
> 
> Diffs
> -----
> 
>   outputview/CMakeLists.txt b15d640f4486e863dd90caa8560f9c332cc66810 
>   outputview/outputfilteringstrategies.cpp f2e65e115644d04d1bb362d31d30d149a8071d00 
> 
> Diff: https://git.reviewboard.kde.org/r/115506/diff/
> 
> 
> Testing
> -------
> 
> The search works for kdevelop and kdevplatform.
> 
> It should ideally be tested on a project where he build directory is not an immediate child of the source directory, but I did not have such a project at the time of posting this patch. 
> 
> 
> Thanks,
> 
> Todd Nowacki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140206/ac5741a6/attachment.html>