Review Request 115518: Implement IBuddyDocumentFinder interface.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115518/#review49130
-----------------------------------------------------------



documentfinderhelpers.cpp
<https://git.reviewboard.kde.org/r/115518/#comment34704>

    here and below: I'd store that in a static const and return that then. no need to re-create that set over and over again.



documentfinderhelpers.cpp
<https://git.reviewboard.kde.org/r/115518/#comment34705>

    same here, this could easily be cached in a local static const


- Milian Wolff


On Feb. 6, 2014, 1:42 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115518/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 1:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Now it's possiple to switch between source/header files.
> 
> note: this is 80% copy/paste from current cpp plugin
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8e83026 
>   clanglanguagesupport.h cf8d907 
>   clanglanguagesupport.cpp e18ab74 
>   documentfinderhelpers.h PRE-CREATION 
>   documentfinderhelpers.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140206/12d2d44b/attachment.html>