Review Request 115506: A fix so CMake errors link to the proper file.

[Morten Volden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115506/#review49082
-----------------------------------------------------------


Hi Todd. Thanks for the patch :-). I have just had a few minuttes to look through the code, so here is a few nitpicks from me. Will see if I can give it a more thorough look tomorrow.


outputview/outputfilteringstrategies.cpp
<https://git.reviewboard.kde.org/r/115506/#comment34663>

    Could you pls. move the item to next line



outputview/outputfilteringstrategies.cpp
<https://git.reviewboard.kde.org/r/115506/#comment34664>

    Pls. remove white space 



outputview/outputfilteringstrategies.cpp
<https://git.reviewboard.kde.org/r/115506/#comment34666>

    Same here



outputview/outputfilteringstrategies.cpp
<https://git.reviewboard.kde.org/r/115506/#comment34667>

    .. and here



outputview/outputfilteringstrategies.cpp
<https://git.reviewboard.kde.org/r/115506/#comment34665>

    Are we 100% certain that d->m_sourceDir is always found? - If not, this line will be problematic


- Morten Volden


On Feb. 5, 2014, 8:58 p.m., Todd Nowacki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115506/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 8:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 321982
>     http://bugs.kde.org/show_bug.cgi?id=321982
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Before, it was assumed that the build directory was an immediate child of the source directory.
> 
> Now, we iterate through each project (via the project controller) to find a project with a matching build directory and grab the source directory from that project. 
> 
> 
> Diffs
> -----
> 
>   outputview/CMakeLists.txt b15d640f4486e863dd90caa8560f9c332cc66810 
>   outputview/outputfilteringstrategies.cpp f2e65e115644d04d1bb362d31d30d149a8071d00 
> 
> Diff: https://git.reviewboard.kde.org/r/115506/diff/
> 
> 
> Testing
> -------
> 
> The search works for kdevelop and kdevplatform.
> 
> It should ideally be tested on a project where he build directory is not an immediate child of the source directory, but I did not have such a project at the time of posting this patch. 
> 
> 
> Thanks,
> 
> Todd Nowacki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140205/b5857069/attachment.html>