Review Request 115303: Add different clang options depending on the mimetype

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115303/#review49026
-----------------------------------------------------------



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115303/#comment34628>

    this could actually map QString to QVector<const char*> which would simplify the usage below



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115303/#comment34625>

    I'd put the default out of the map



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115303/#comment34627>

    use name()



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115303/#comment34626>

    add whitespaces around operators please. I'd even go as far as not using the ternary operator here at all:
    
    if (it != mimeToArgs.end()) {
      return it->second;
    } else {
      return defaultArgs;
    }


- Milian Wolff


On Feb. 5, 2014, 2:10 p.m., Damian Kaczmarek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115303/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 2:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Provides means to pass different options depending on different mimetypes. Currently no new mimetypes added.
> 
> 
> Diffs
> -----
> 
>   duchain/parsesession.cpp 0848e33 
> 
> Diff: https://git.reviewboard.kde.org/r/115303/diff/
> 
> 
> Testing
> -------
> 
> Yes. Compiles with GCC and Clang.
> 
> 
> Thanks,
> 
> Damian Kaczmarek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140205/acb1d040/attachment.html>