Review Request 115446: Make Best matches items re-use MatchQuality property.

Milian Wolff mail at milianw.de
Wed Feb 5 11:42:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115446/#review49014
-----------------------------------------------------------



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/115446/#comment34618>

    some comments here would be useful, i.e. "don't set best match for internal identifiers"
    
    and
    
    "prefer declarations from current file"


- Milian Wolff


On Feb. 5, 2014, 8:08 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115446/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 8:08 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Also sort Best matches items a little bit. From now on items from the current file will be shown at the top of the completion list.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 6c4df1c 
> 
> Diff: https://git.reviewboard.kde.org/r/115446/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/05/b80b6163-80f6-423d-82cb-12ccf43a7c7f__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/05/f646df78-1a60-430a-a0fe-8f640a81df40__after.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140205/3b7c6edc/attachment.html>


More information about the KDevelop-devel mailing list