Review Request 115479: Add support for custom include paths

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115479/#review48959
-----------------------------------------------------------


looks cool, some small things are left


clangparsejob.cpp
<https://git.reviewboard.kde.org/r/115479/#comment34567>

    const&



clangparsejob.cpp
<https://git.reviewboard.kde.org/r/115479/#comment34566>

    const&



clangparsejob.cpp
<https://git.reviewboard.kde.org/r/115479/#comment34568>

    cool, but couldn't the same be achieved without boost but a simple lambda instead?



clangparsejob.cpp
<https://git.reviewboard.kde.org/r/115479/#comment34569>

    const&


- Milian Wolff


On Feb. 4, 2014, 5:30 p.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115479/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 5:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Partially ported from kdevcppsupport plugin
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 61da5ca 
> 
> Diff: https://git.reviewboard.kde.org/r/115479/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140204/654b4cf2/attachment.html>