Review Request 115445: Port refactoring progress dialog to kdevplatform

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115445/#review48826
-----------------------------------------------------------

Ship it!


one small issue, then go ahead!

thanks


language/codegen/progressdialogs/refactoringdialog.h
<https://git.reviewboard.kde.org/r/115445/#comment34469>

    const&



language/codegen/progressdialogs/refactoringdialog.h
<https://git.reviewboard.kde.org/r/115445/#comment34470>

    


- Milian Wolff


On Feb. 3, 2014, 11:44 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115445/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 11:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Also simplify it, port to .ui and show endless progress bar as UsesCollector doesn't update it's state properly.
> 
> Note: This patch based on 115383 review, which is not yet commited. 
> Milian, could I commit that review already?
> 
> 
> Diffs
> -----
> 
>   language/codegen/progressdialogs/refactoringdialog.ui PRE-CREATION 
>   language/codegen/progressdialogs/refactoringdialog.cpp PRE-CREATION 
>   language/codegen/progressdialogs/refactoringdialog.h PRE-CREATION 
>   language/CMakeLists.txt 6815409 
>   language/codegen/basicrefactoring.cpp d5e8c67 
> 
> Diff: https://git.reviewboard.kde.org/r/115445/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/03/925c5843-e211-4b30-a98a-e058ffb5f224__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/03/dbacde15-fb3a-4bf1-a3ce-0cb9ff7238b1__after.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140203/f6622118/attachment.html>