Review Request 115383: Reuse code in Refactor widget. Changes in kdevplatform

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115383/#review48825
-----------------------------------------------------------

Ship it!


two small issues, then I'm fine with this!


language/codegen/basicrefactoring.h
<https://git.reviewboard.kde.org/r/115383/#comment34467>

    const& the DeclarationPointer



language/codegen/basicrefactoring.cpp
<https://git.reviewboard.kde.org/r/115383/#comment34468>

    first acquire the lock, then check the validity of the declaration and return


- Milian Wolff


On Jan. 31, 2014, 8:41 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115383/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 8:41 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Refactore code out a little bit so that language plugins can reuse even more code if they want to reimplement startInteractiveRename function.
> 
> 
> Diffs
> -----
> 
>   language/duchain/navigation/useswidget.cpp 2fd0bd9 
>   language/duchain/navigation/useswidget.h f52d868 
>   language/codegen/basicrefactoring.cpp d5e8c67 
>   language/codegen/basicrefactoring.h 06606a5 
> 
> Diff: https://git.reviewboard.kde.org/r/115383/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140203/5cb90dce/attachment.html>