Review Request 115446: Further kdev-clang code completion improvements.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115446/#review48824
-----------------------------------------------------------


Please split this commit into smaller chunks, each one handling one of your bullet points.

And yes, I'd welcome if you could continue pushing patches to reviewboard first. Thanks!


codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/115446/#comment34466>

    Instead of removing this, I initially wanted to make use of the KTextEditor::TemplateInterface, which you can see in action in the snippets. That would allow us to quickly navigate between the placeholders, replace them and continue adding code after the function. 
    
    Anyhow, I don't think you have to do that now, so I'm OK with disabling this for now. But please add a comment at least here.



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/115446/#comment34465>

    while this does help showing the overloaded items, it does so in a very costly way (repeatedly looking up the qid declarations). So rather, I suggest keeping the existing qid-based QSet but adding items for all overloaded items at once.



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/115446/#comment34464>

    this should instead use ClassDeclaration::isPublicBaseClass and its argument to find the depth. Or maybe even found->context()->depth() ?


- Milian Wolff


On Feb. 3, 2014, 12:25 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115446/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 12:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> *Don't insert arguments of a function into text on execute(..)
> *Append () to functions 
> *Properly (I hope...) handle overloaded functions.
> *Show local items above others.
> 
> P.S: Now, when I've got commit rights, should I still post these patches for review or not?
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 6c4df1c 
> 
> Diff: https://git.reviewboard.kde.org/r/115446/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140203/932c4884/attachment-0001.html>