Review Request 121574: Search for modules in custom include paths

Sergey Kalinichev kalinichev.so.0 at gmail.com
Wed Dec 31 12:53:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121574/#review72840
-----------------------------------------------------------


Never worked with kdev-python, but the patch seems good for me.


duchain/helpers.cpp
<https://git.reviewboard.kde.org/r/121574/#comment50719>

    Use IDefinesAndIncludesManager::manager() instead


- Sergey Kalinichev


On Dec. 17, 2014, 1:17 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121574/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 1:17 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Search for modules in custom include paths
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a0384e59a2e292104ad819122f1b4f08aad7c4a2 
>   duchain/CMakeLists.txt 6cfb0c0500bc78eeacf9602c83d5e00feb311e2a 
>   duchain/helpers.cpp 6a64e2f622cd015cc59a3db6d69ab281121df461 
> 
> Diff: https://git.reviewboard.kde.org/r/121574/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141231/37bf1964/attachment.html>


More information about the KDevelop-devel mailing list