Review Request 121775: Correctly load dependencies for plugins

Sergey Kalinichev kalinichev.so.0 at gmail.com
Wed Dec 31 12:34:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121775/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevplatform


Description
-------

Currently if some plugin depends on another one that's not yet loaded, the former one won't be loaded too.

This happens because checkForDependencies returns false if there are some dependencies, but the code that calls this method threats false return code as an error, so it doesn't try to load any dependencies at all.


Diffs
-----

  shell/plugincontroller.h 89b0b8b 
  shell/plugincontroller.cpp f70fc64 

Diff: https://git.reviewboard.kde.org/r/121775/diff/


Testing
-------


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141231/d3666dab/attachment.html>


More information about the KDevelop-devel mailing list