Review Request 121649: For headers, also use source-file include paths and defines.

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121649/#review72812
-----------------------------------------------------------


Rather embarassing that I didn't notice this sooner. I came up with a completely different solution: https://git.reviewboard.kde.org/r/121757/  

The advantage of what I have is that it should work for headers that have no buddy but are otherwise used anywhere in the project.

Of course my solution doesn't actually work right now (CMake doesn't build targets, but that needs to be fixed?) so about this:
1. This might useful in addition to the other as a "first guess" before any "target" TUs are found/created
2. I /really/ think it would be better to use the TU of the cpp rather than merging the includes. Is that significantly more work?

- Olivier Jean de Gaalon


On Dec. 23, 2014, 5:28 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121649/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 5:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> We use the existing find-buddy-document architecture to find a
> source file corresponding to the current header file. If we find
> a match that also has a project file, we ask it for its include
> files.
> 
> This fixes an issue, where when editing a header file Clang would
> never find the include paths. The reason is that in e.g. CMake,
> only the .cpp files have include paths, but not the .h files.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 297b836128c441a7f6aacbac7ec175ca4bf7b8e1 
>   duchain/clangparsingenvironment.cpp 1decc1493eba5b81d18937ce43dd5c24ea6db01f 
> 
> Diff: https://git.reviewboard.kde.org/r/121649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141231/4cc6b001/attachment.html>