Review Request 121690: Port from KPluginInfo to KPluginMetaData

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121690/#review72630
-----------------------------------------------------------

Ship it!


In general: LGTM -> Ship it


interfaces/iplugincontroller.h
<https://git.reviewboard.kde.org/r/121690/#comment50603>

    Remove, we'll fix the compile errors in users of this header.



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50604>

    Really?



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50610>

    Since it's not a key on its own, cll it `KEY_Suffix_Enabled`?



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50605>

    Use KEY_Enabled?



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50611>

    Likewise, introduce Key_SUFFIX_Disabled?



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50606>

    constify, otherwise range-based for will detach the container.
    
    In general I prefer foreach for Qt containers just because of this trap.
    
    For reference: http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50607>

    Same here



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121690/#comment50608>

    Dito


- Kevin Funk


On Dec. 27, 2014, 2:11 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121690/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 2:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port from KPluginInfo to KPluginMetaData
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/tests/test_standardoutputview.cpp 8159560be2eaba42a931da8f64ec954d020cfb25 
>   shell/documentcontroller.cpp 8b3fde4f218b11ad9cb126224302bdff52ee74c3 
>   shell/languagecontroller.cpp 5f0a8c15f65f697df837ec634cb1508188e28e67 
>   shell/loadedpluginsdialog.cpp 10787a41e8094208f41bd6a6e025539377321581 
>   interfaces/iplugincontroller.h 687c1a0f00f94b9d6cf793dba4adfd79947172ac 
>   plugins/appwizard/appwizardplugin.cpp e8e9472caa62370191647bdc6fbc456837f0e96f 
>   plugins/appwizard/projectvcspage.cpp 2127caf7697ebdc7f92b11a07100d86098e63343 
>   plugins/contextbrowser/contextbrowser.cpp 5771c92e9a8eb6604ec1e97a9d504487c0655fcd 
>   plugins/dashboard/appletselector.cpp 32c616b7a64b5d61f90d854b233c80c17872f397 
>   plugins/patchreview/patchreviewtoolview.cpp 17e63be67244a02d5804c7e0d97e0138848bc163 
>   shell/openprojectpage.cpp b551b0511583a6dbd6edc16a30f1f4d7148a3e1c 
>   shell/plugincontroller.h 65aeed01e5d1547716882d75de124c7366a1665a 
>   shell/plugincontroller.cpp f24be065a293f0112227ba20f51159d377e47a88 
>   shell/project.cpp 19dcb1122338f3d1ab6f296193c3f9b50ec4e91d 
>   shell/projectcontroller.cpp 6eeb434609749c8cdef1e53537efd8023d5dcc54 
>   shell/projectinfopage.cpp 19984009928257ee4c272b93dc814afafe20315b 
>   shell/projectsourcepage.cpp d6c1ac1a604eb4af33575fea80e6ed55ecd12c66 
>   shell/session.cpp 079e3ce63b1698446f1d35b7de6c8da73beca50c 
>   shell/settings/pluginpreferences.cpp 4b8be9db715ce9fd8d98eabac617a424d11ec879 
>   shell/settings/sourceformattersettings.cpp 2421bd12d2eacf85383f96758a17c79c02b2b91e 
>   shell/sourceformattercontroller.h b53660cbe9011a60b90d7f6c9c96e5dba1d95234 
>   shell/sourceformattercontroller.cpp eee6bd243ad41ca9fe738476fe1b155989b71e77 
>   shell/tests/test_plugincontroller.cpp fae7654c3bd48f61374bfcd1c50047f25febdefe 
>   shell/textdocument.cpp 3e47a412069eef381579b0f1a5cd3069334359f0 
>   tests/testplugincontroller.h 674c91e4393ea3ccdfd6a5204ee2c4d66e96443d 
>   tests/testplugincontroller.cpp 2e00bebca322539c0105b1d164398808e8255ae3 
>   vcs/models/projectchangesmodel.cpp 153af358d618e249e364ef1b4f34ccf08bb58411 
>   vcs/vcspluginhelper.cpp c11fbf28a33716393e42d5a0411e808a54a2fc8d 
> 
> Diff: https://git.reviewboard.kde.org/r/121690/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141228/931fc95f/attachment-0001.html>