Review Request 121681: Fix compilation

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121681/#review72528
-----------------------------------------------------------


Maybe using std::unique_ptr instead of explicit deletes might be a good idea, but otherwise it looks good to me.

Someone else should probably give the ship it since I am not familiar with the code here.

- Alex Richardson


On Dez. 26, 2014, 4:05 nachm., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121681/
> -----------------------------------------------------------
> 
> (Updated Dez. 26, 2014, 4:05 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Just a few porting bits to make it compile again without KDELibs4Support:
> - port away from KIcon
> - port away from KIO::NetAccess
> - kDebug() -> qDebug() (actually I've enforced kDebug(int) -> qDebug() as I found no reason to keep that categorization in one place. If I'm mistaken let me know)
> 
> 
> Diffs
> -----
> 
>   allprofilesmodel.cpp 3ee6053 
>   kdevuploadplugin.cpp 3f05752 
>   profilesfiletree.cpp 45152f6 
>   uploaddialog.cpp 8d0c7a1 
>   uploadjob.cpp ebe556b 
>   uploadpreferences.cpp 1fe0d72 
>   uploadprofiledlg.cpp ac0fba2 
>   uploadprofileitem.cpp f957ce4 
>   uploadprofilemodel.cpp bc5153f 
>   uploadprojectmodel.cpp c7ddacf 
> 
> Diff: https://git.reviewboard.kde.org/r/121681/diff/
> 
> 
> Testing
> -------
> 
> Compiles and works in simple cases I've tried.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141226/2e170425/attachment.html>