Review Request 121626: Move Q_DECLARE_OPERATORS_FOR_FLAGS out of namespaces

[Nicolai Hähnle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121626/
-----------------------------------------------------------

(Updated Dec. 21, 2014, 11:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdevplatform


Description
-------

Having the macro expanded while not in the global namespace messes with the
precedence rules of operator| in a way that prevents the QFlags mechanism
from working correctly.

Observe one additional change which was necessary precisely because somebody
had previously used a C-style cast to work around this breakage.


Diffs
-----

  language/backgroundparser/parsejob.h c2e272d296720a644d6a847a38e8d82457af7ce5 
  language/duchain/abstractfunctiondeclaration.h 3cf677768ced3a5bbc9bbd6dc56781938b0ebff5 
  language/duchain/navigation/abstractnavigationcontext.h c5c10d63fe6b958f8cd1fbf3183189a1df6cc45c 
  shell/documentcontroller.cpp f6497120a6a27bcd5b605458e438708a476c36b9 

Diff: https://git.reviewboard.kde.org/r/121626/diff/


Testing
-------

still compiles


Thanks,

Nicolai Hähnle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141221/8a338100/attachment.html>