Review Request 121627: Move Q_DECLARE_OPERATORS_FOR_FLAGS out of namespaces
Milian Wolff
mail at milianw.de
Sun Dec 21 23:16:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121627/#review72389
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On Dec. 21, 2014, 10:57 p.m., Nicolai Hähnle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121627/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2014, 10:57 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Having the macro expanded while not in the global namespace messes with the
> precedence rules of operator| in a way that prevents the QFlags mechanism
> from working correctly.
>
>
> Diffs
> -----
>
> debuggers/gdb/gdbglobal.h 6a64cce298df55f2d03720d1fb294e8849dbaf16
> languages/cpp/codegen/makeimplementationprivate.h 211a947ad2914277aa7f03ec1199ff1c301ab31a
>
> Diff: https://git.reviewboard.kde.org/r/121627/diff/
>
>
> Testing
> -------
>
> still compiles
>
>
> Thanks,
>
> Nicolai Hähnle
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141221/87a2bc3f/attachment.html>
More information about the KDevelop-devel
mailing list