Review Request 121617: gdb: adjust DebugSession for the interface cleanup in kdevplatform

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121617/#review72383
-----------------------------------------------------------



debuggers/gdb/debugsession.h
<https://git.reviewboard.kde.org/r/121617/#comment50454>

    shouldn't all this be marked `override`? or are these new functions that can be overriden by subclasses? if the latter, then documentation is missing



debuggers/gdb/debugsession.cpp
<https://git.reviewboard.kde.org/r/121617/#comment50455>

    whitespaces around | please


- Milian Wolff


On Dec. 21, 2014, 3:34 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121617/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2014, 3:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> These are the necessary changes to go with the changes from review 121616 in kdevplatform.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.h da6125e9d85f946e39b5ecd81cb2cfd8dc3e8b3b 
>   debuggers/gdb/debugsession.cpp 5c72fe371cca1a3d9a0d62926357d7a4a5aa5f8d 
> 
> Diff: https://git.reviewboard.kde.org/r/121617/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141221/48397270/attachment.html>