Review Request 121624: port kdevcustombuildsystem.desktop to new .json format

[Laurent Navet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121624/
-----------------------------------------------------------

(Updated Dec. 21, 2014, 9:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdevelop


Description
-------

port kdevcustombuildsystem.desktop to new .json format

Extract from http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/

Having the metadata baked into the plugin allows us to not use KServiceTypeTrader (which handles the searching through the sycoca cache) but to ask QPluginLoader directly. Right now, we’re still using sycoca for the lookup, but this mechanism allows us to move away from it in the future.

I can do other plugins as well.


Diffs
-----

  projectmanagers/custom-buildsystem/CMakeLists.txt 70ed269 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp 3f85e50 

Diff: https://git.reviewboard.kde.org/r/121624/diff/


Testing
-------

build, run, plugin is loaded without the warning at startup saying that the plugin use the old .desktop file based metadata.


Thanks,

Laurent Navet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141221/94167886/attachment-0001.html>