Review Request 121600: sublime: prevent accidentally adding nullptrs to ContainerPrivate::viewForWidget

[Nicolai Hähnle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121600/
-----------------------------------------------------------

(Updated Dec. 19, 2014, 11:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Bugs: 342037
    http://bugs.kde.org/show_bug.cgi?id=342037


Repository: kdevplatform


Description
-------

The likely culprit here is using operator[] to access a map, which implicitly
creates an entry containing a null view. I have audited all other accesses of
viewForWidget with operator[] to verify that they happen in a context where
the entry is non-null (either because the access is used to assign a non-null
view pointer or because the access is guaranteed to crash or abort immediately
if it would create an incorrect nullptr entry).

BUG: 342037


Diffs
-----

  sublime/container.cpp aac4b11679fcb7a04e8aee7f831c95b0d1e4192c 

Diff: https://git.reviewboard.kde.org/r/121600/diff/


Testing
-------

manual testing


Thanks,

Nicolai Hähnle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141219/124cbfb1/attachment-0001.html>