Review Request 121568: FramestackWidget: properly initialize when a session already exists

Aleix Pol Gonzalez aleixpol at kde.org
Wed Dec 17 00:47:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121568/#review72152
-----------------------------------------------------------

Ship it!


Seems to make sense. Also makes the code lighter to read.

- Aleix Pol Gonzalez


On Dec. 17, 2014, 12:45 a.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121568/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 12:45 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 333756
>     http://bugs.kde.org/show_bug.cgi?id=333756
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> While there, clean up redundant (and potentially incorrect) hideEvent and
> showEvent.
> 
> 
> Diffs
> -----
> 
>   debugger/framestack/framestackwidget.h 9f4e6ffe55554d110dafdcc47fb3355802325625 
>   debugger/framestack/framestackwidget.cpp 0266b3b7894107107334e62ae28619bd8397f8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/121568/diff/
> 
> 
> Testing
> -------
> 
> manual testing of the UI
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141217/15fcc66a/attachment.html>


More information about the KDevelop-devel mailing list