Review Request 121338: Fix bug on multi-line function-macro expansion, format preprocessed body for Cpp::NavigationWidget
Milian Wolff
mail at milianw.de
Tue Dec 16 11:38:54 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121338/#review72113
-----------------------------------------------------------
Ship it!
Looks good now - thanks! can you send me the patch via email, apparently reviewboard has a bug currently and doesn't let me download your patch... You can send it to mail at milianw.de, then I'll apply it.
Thanks again!
- Milian Wolff
On Dec. 16, 2014, 2:10 a.m., Zhang HuiJie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121338/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 2:10 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Fix bug on multi-line function-macros expansion, format preprocessed body for Cpp::NavigationWidget.
>
>
> Diffs
> -----
>
> languages/cpp/parser/rpp/pp-scanner.cpp 28479d8
> languages/cpp/parser/tests/test_parser.cpp 0132ed5
> languages/cpp/cpplanguagesupport.cpp 79530e9
> languages/cpp/parser/rpp/pp-engine.cpp 8f6c8da
> languages/cpp/parser/rpp/pp-scanner.h 94fab52
>
> Diff: https://git.reviewboard.kde.org/r/121338/diff/
>
>
> Testing
> -------
>
> This patch work well on multi-line macros expansion, and unit test passed.
>
>
> Thanks,
>
> Zhang HuiJie
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141216/3943f096/attachment.html>
More information about the KDevelop-devel
mailing list