Review Request 121338: Fix bug on multi-line function-macro expansion, format preprocessed body for Cpp::NavigationWidget

[Kevin Funk]

> On Dec. 15, 2014, 10:44 a.m., Milian Wolff wrote:
> > languages/cpp/parser/rpp/test/t012.cpp, line 1
> > <https://git.reviewboard.kde.org/r/121338/diff/3/?file=332125#file332125line1>
> >
> >     sorry for the confusing code architecture, but I don't think these files are actually "tested". I.e. you can write in here whatever you like, and it won't ever be noticed ;-)
> >     
> >     I'll actually remove these files. Instead, please add your code to e.g. cpp/parser/tests/test_parser.cpp, e.g. within `testPreprocessor`, which will also show you how to run an example through the preprocessor, and how to compare its results to an expected outcome.

Oh, wow, didn't know. Sorry for getting you on the wrong track with those unit tests, Zhang ;)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121338/#review72033
-----------------------------------------------------------


On Dec. 7, 2014, 2:31 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121338/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2014, 2:31 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Fix bug on multi-line function-macros expansion, format preprocessed body for Cpp::NavigationWidget.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/rpp/test/t012.cpp PRE-CREATION 
>   languages/cpp/parser/rpp/pp-engine.cpp 8f6c8da 
>   languages/cpp/parser/rpp/pp-scanner.h 94fab52 
>   languages/cpp/parser/rpp/pp-scanner.cpp 28479d8 
>   languages/cpp/cpplanguagesupport.cpp 79530e9 
> 
> Diff: https://git.reviewboard.kde.org/r/121338/diff/
> 
> 
> Testing
> -------
> 
> This patch work well on multi-line function-macros expansion, no test will fail because of this patch.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141215/f1f36dad/attachment.html>