Review Request 121481: gdb: defend against use-after-free of breakpoint structures

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121481/#review71962
-----------------------------------------------------------



debuggers/gdb/breakpointcontroller.cpp
<https://git.reviewboard.kde.org/r/121481/#comment50177>

    bkpt was special, and is not, anymore - intentional change? maybe just do
    
        if (r.hasField("bkpt")) {
          controller->update...
        } else {
          for (auto kind : {"wpt", ...}) {
             ...
          }
        }


- Milian Wolff


On Dec. 13, 2014, 8:14 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121481/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2014, 8:14 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This should prevent the crash observed in https://paste.kde.org/p0vezsuve
> Since I am unable to reproduce that crash, it is unclear whether the scenario
> that lead to the crash is handled completely correctly now.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/breakpointcontroller.h e5338f4f497ee0997de637db80c071b565bc9322 
>   debuggers/gdb/breakpointcontroller.cpp a85b441e9622a1b00069e2419d41e1d1d4b20800 
> 
> Diff: https://git.reviewboard.kde.org/r/121481/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141214/bb115e7b/attachment.html>