Review Request 121436: grepview: fix two crashes

[Nicolai Hähnle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121436/
-----------------------------------------------------------

(Updated Dez. 10, 2014, 10:14 nachm.)


Review request for KDevelop.


Changes
-------

Update for Milian's comments.


Repository: kdevplatform


Description
-------

The first crash is a crash-on-exit, when the kill() method of a no longer existing job is called. Guard againsts this crash by using a QPointer.

The second crash happens when GrepOutputDelegate::sizeHint() is called while using the combo-box of the grep output view to switch to previous search results. Simply change the code to be more defensive.


Diffs (updated)
-----

  plugins/grepview/grepdialog.cpp bb00e47 
  plugins/grepview/grepoutputdelegate.cpp bcd911b 

Diff: https://git.reviewboard.kde.org/r/121436/diff/


Testing
-------

manual testing / daily use


Thanks,

Nicolai Hähnle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141210/fb1a6f1c/attachment-0001.html>