Review Request 121436: grepview: fix two crashes

Nicolai Hähnle nhaehnle at
Wed Dec 10 22:14:00 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Dez. 10, 2014, 10:14 nachm.)

Review request for KDevelop.


Update for Milian's comments.

Repository: kdevplatform


The first crash is a crash-on-exit, when the kill() method of a no longer existing job is called. Guard againsts this crash by using a QPointer.

The second crash happens when GrepOutputDelegate::sizeHint() is called while using the combo-box of the grep output view to switch to previous search results. Simply change the code to be more defensive.

Diffs (updated)

  plugins/grepview/grepdialog.cpp bb00e47 
  plugins/grepview/grepoutputdelegate.cpp bcd911b 



manual testing / daily use


Nicolai Hähnle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list