Review Request 121434: PatchReview: only attempt to add highlighting when a patch is active

[Nicolai Hähnle]

> On Dez. 10, 2014, 3:29 nachm., Aleix Pol Gonzalez wrote:
> > Ship It!

Thank you. Also here: I don't remember ever having a developer account.


- Nicolai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121434/#review71716
-----------------------------------------------------------


On Dez. 10, 2014, 3:18 nachm., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121434/
> -----------------------------------------------------------
> 
> (Updated Dez. 10, 2014, 3:18 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Before this change, an exception is thrown in addHighlighting() for every document that is opened regularly, which is very annoying when debugging KDevelop.
> 
> I also suggest changing the Kate modeline, because the standard indentation is 4 spaces, and the file itself is currently a bit inconsistent with the indentation.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp a178c0d 
> 
> Diff: https://git.reviewboard.kde.org/r/121434/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141210/64f4d288/attachment.html>