Review Request 121434: PatchReview: only attempt to add highlighting when a patch is active
Nicolai Hähnle
nhaehnle at gmail.com
Wed Dec 10 15:18:19 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121434/
-----------------------------------------------------------
Review request for KDevelop.
Repository: kdevplatform
Description
-------
Before this change, an exception is thrown in addHighlighting() for every document that is opened regularly, which is very annoying when debugging KDevelop.
I also suggest changing the Kate modeline, because the standard indentation is 4 spaces, and the file itself is currently a bit inconsistent with the indentation.
Diffs
-----
plugins/patchreview/patchreview.cpp a178c0d
Diff: https://git.reviewboard.kde.org/r/121434/diff/
Testing
-------
manual testing
Thanks,
Nicolai Hähnle
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141210/0f854208/attachment.html>
More information about the KDevelop-devel
mailing list