Review Request 121393: serialization bench tests: build only if compiler optimizations are enabled

[Milian Wolff]

> On Dec. 9, 2014, 12:58 a.m., Milian Wolff wrote:
> > yay, you are welcome to introduce these checks in other places as well!
> > 
> > thanks
> 
> Laurent Navet wrote:
>     I've searched with "find . -name *bench*" and that was the only one. Do you know other tests which need this check ?

I think that in some places, I was lazy and added benchmarks in the same file as the unit tests. Separating that would be nice, eventually. But low-priority of course.

thanks!


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121393/#review71605
-----------------------------------------------------------


On Dec. 8, 2014, 8:59 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121393/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 8:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> no need to build or run bench when optimizations are disabled
> 
> 
> Diffs
> -----
> 
>   serialization/tests/CMakeLists.txt eb37ad6 
> 
> Diff: https://git.reviewboard.kde.org/r/121393/diff/
> 
> 
> Testing
> -------
> 
> builds fine
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141209/aeb9bf9f/attachment.html>