Review Request 121391: Avoid inappropriate warning from gdb CMakeLists.txt
Kevin Funk
kfunk at kde.org
Mon Dec 8 22:51:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121391/#review71597
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Funk
On Dec. 8, 2014, 10:26 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121391/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:26 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Warning about faulty ninja build files is inappropriate if the ninja generator isn't being used.
>
> In addition, the warning should probably be suppressed when using cmake 3.0 and higher, or else it ought to be reworded ... (it prints for me with cmake 3.0.2)
>
>
> Diffs
> -----
>
> debuggers/gdb/CMakeLists.txt 8b78e56
>
> Diff: https://git.reviewboard.kde.org/r/121391/diff/
>
>
> Testing
> -------
>
> With cmake 3.0.2 on OS X 10.9.4 (ought to be OS independent) and the Unix Makefiles generator.
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141208/659901c3/attachment-0001.html>
More information about the KDevelop-devel
mailing list