Review Request 121391: Avoid inappropriate warning from gdb CMakeLists.txt

[René J.V. Bertin]

> On Dec. 8, 2014, 8:22 p.m., Milian Wolff wrote:
> > debuggers/gdb/CMakeLists.txt, line 33
> > <https://git.reviewboard.kde.org/r/121391/diff/1/?file=332273#file332273line33>
> >
> >     this is still wrong. the `HAVE_*` define should also be set, when the generator does not equal `"Ninja"`. Do something like
> >     
> >     `if(CMAKE_VERSION VERSION_GREATE "2.9" OR NOT CMAKE_GENERATOR MATCHES "Ninja")
> >       ...
> >     `
> 
> René J.V. Bertin wrote:
>     I think that my modification makes cmake behave like what the code tried to do, but you're saying that was not what should be done?
>     Maybe you should say more about the issue...
>     - are all cmake versions after 2.9 concerned?
>     - are all generators concerned?
>     - what `HAVE_` define should be set?
> 
> Kevin Funk wrote:
>     What Milian said: CMake creates faulty ninja files when 'Ninja used' && 'CMake < v3.0', rest is fine.
>     
>     Sorry for breaking this for the Makefiles generator, it was late. :)
>     
>     Please update the review-request and make sure it works for you

Ahhh, *that* `HAVE_` define ... doh ...

And of course re-reading Milian's suggestion I realise it can indeed be done in a single check. Will re-upload...

You didn't really break anything (not having this particular test isn't a big deal AFAIC), just the warning was a bit silly and had me second-guessing myself for a moment. After all, I did just update kdevelop ;)


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121391/#review71583
-----------------------------------------------------------


On Dec. 8, 2014, 8:11 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121391/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 8:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Warning about faulty ninja build files is inappropriate if the ninja generator isn't being used.
> 
> In addition, the warning should probably be suppressed when using cmake 3.0 and higher, or else it ought to be reworded ... (it prints for me with cmake 3.0.2)
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/CMakeLists.txt 8b78e56 
> 
> Diff: https://git.reviewboard.kde.org/r/121391/diff/
> 
> 
> Testing
> -------
> 
> With cmake 3.0.2 on OS X 10.9.4 (ought to be OS independent) and the Unix Makefiles generator.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141208/ec4df932/attachment.html>