Review Request 121391: Avoid inappropriate warning from gdb CMakeLists.txt

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121391/#review71583
-----------------------------------------------------------



debuggers/gdb/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121391/#comment49919>

    this is still wrong. the `HAVE_*` define should also be set, when the generator does not equal `"Ninja"`. Do something like
    
    `if(CMAKE_VERSION VERSION_GREATE "2.9" OR NOT CMAKE_GENERATOR MATCHES "Ninja")
      ...
    `


- Milian Wolff


On Dec. 8, 2014, 7:11 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121391/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 7:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Warning about faulty ninja build files is inappropriate if the ninja generator isn't being used.
> 
> In addition, the warning should probably be suppressed when using cmake 3.0 and higher, or else it ought to be reworded ... (it prints for me with cmake 3.0.2)
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/CMakeLists.txt 8b78e56 
> 
> Diff: https://git.reviewboard.kde.org/r/121391/diff/
> 
> 
> Testing
> -------
> 
> With cmake 3.0.2 on OS X 10.9.4 (ought to be OS independent) and the Unix Makefiles generator.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141208/26c1eeaa/attachment.html>