Review Request 121373: cleanup : use IDocumentation::Ptr

Kevin Funk kfunk at kde.org
Sat Dec 6 22:59:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121373/#review71492
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Dec. 6, 2014, 10:36 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121373/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 10:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> remove all QExplicitlySharedPointer<KDevelop::IDocumentation>
> the same has been done in kdevplatform
> see https://projects.kde.org/projects/extragear/kdevelop/kdevplatform/repository/revisions/5d4f3c668cb7ba12ee3fea803d4ececa4b1da134
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakedocumentation.h cba5ba1 
>   projectmanagers/cmake/cmakedocumentation.cpp 4304d59 
>   projectmanagers/cmake/cmakenavigationwidget.h 68a22b1 
>   projectmanagers/cmake/cmakenavigationwidget.cpp 5133de7 
>   projectmanagers/cmake/icmakedocumentation.h 6919e32 
> 
> Diff: https://git.reviewboard.kde.org/r/121373/diff/
> 
> 
> Testing
> -------
> 
> build, run and test pass (the same fails as before this patch)
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20141206/80473ee6/attachment.html>


More information about the KDevelop-devel mailing list