Review Request 119985: Prevent the deletion of files that are used as unit test comparison

Aleix Pol Gonzalez aleixpol at kde.org
Fri Aug 29 10:53:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119985/#review65475
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On ago. 29, 2014, 10:08 a.m., Simon Wächter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119985/
> -----------------------------------------------------------
> 
> (Updated ago. 29, 2014, 10:08 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch fixes a problem that I introduced when I ported the app template and file template wizard to KF5. The problem in the unit test was, that the wrong working directory was used and the auto cleanup accidentaly deleted the wrong files (These files were used as comparision for the test result).
> 
> Now the unit test creates and uses an own directory.
> 
> 
> Diffs
> -----
> 
>   language/codegen/tests/codegen_tests_config.h.cmake b983551 
>   language/codegen/tests/test_templateclassgenerator.cpp 387b507 
> 
> Diff: https://git.reviewboard.kde.org/r/119985/diff/
> 
> 
> Testing
> -------
> 
> Unit tests succeeded several times without a problem on a project neon system.
> 
> 
> Thanks,
> 
> Simon Wächter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140829/88f6bb27/attachment.html>


More information about the KDevelop-devel mailing list