Review Request 119910: Replace KIO::NetAccess with asynchronous KIO::storedPut in FileManager::createNewFile

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119910/#review65082
-----------------------------------------------------------

Ship it!


Rest looks good


plugins/filemanager/filemanager.cpp
<https://git.reviewboard.kde.org/r/119910/#comment45480>

    Style:
    
    if (foo) {
        return;
    }



plugins/filemanager/filemanager.cpp
<https://git.reviewboard.kde.org/r/119910/#comment45481>

    Style: 
    
    We usually attach the '*' to the type. => KJob*



plugins/filemanager/filemanager.cpp
<https://git.reviewboard.kde.org/r/119910/#comment45482>

    Style:
    
    No C-style casts please.
    
    Rather do this at the first lines of the function:
    
    ```
    auto transferJob = qobject_cast<KIO::StoredTransferJob*>(job); Q_ASSERT(transferJob);
    ...
    ```


- Kevin Funk


On Aug. 23, 2014, 12:23 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119910/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2014, 12:23 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Replace KIO::NetAccess with asynchronous KIO::storedPut in FileManager::createNewFile
> Also use QFileDialog instead of KInputDialog
> 
> 
> Diffs
> -----
> 
>   plugins/filemanager/filemanager.h 13e2846ff6a771a89bbd83fc6e18ad2bf20b112a 
>   plugins/filemanager/filemanager.cpp ae0e96eaebebfc15fea0ce06846ff0b45c85f79c 
> 
> Diff: https://git.reviewboard.kde.org/r/119910/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140823/417f83b2/attachment-0001.html>