Review Request 119898: Fix sizeHint for IdealToolButton

Hugo Pereira Da Costa hugo.pereira at
Fri Aug 22 13:27:58 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 22, 2014, 1:27 p.m.)

Review request for KDevelop.


added screenshots 
updated diff to add 4 pixels, that are also hard coded in qtoolbutton

Repository: kdevplatform


As title says:
use sizeFromContents from style rather than fixed spacing and margin, to get the correct size hint. This is similar to what is done in QToolButton and fixes truncated text for styles that add extra spacing (consistently with sizeFromContents) when rendering toolbuttons (this is the case for breeze)

Note: this also removes a "FIXME" comment

Diffs (updated)

  sublime/idealtoolbutton.cpp abecdca 



Tested with oxygen, breeze and fusion.

File Attachments (updated)



Hugo Pereira Da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list