Review Request 119898: Fix sizeHint for IdealToolButton

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119898/
-----------------------------------------------------------

(Updated Aug. 22, 2014, 1:27 p.m.)


Review request for KDevelop.


Changes
-------

added screenshots 
updated diff to add 4 pixels, that are also hard coded in qtoolbutton


Repository: kdevplatform


Description
-------

As title says:
use sizeFromContents from style rather than fixed spacing and margin, to get the correct size hint. This is similar to what is done in QToolButton and fixes truncated text for styles that add extra spacing (consistently with sizeFromContents) when rendering toolbuttons (this is the case for breeze)

Note: this also removes a "FIXME" comment


Diffs (updated)
-----

  sublime/idealtoolbutton.cpp abecdca 

Diff: https://git.reviewboard.kde.org/r/119898/diff/


Testing
-------

Tested with oxygen, breeze and fusion.


File Attachments (updated)
----------------

kdevelop-before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/352aa1d1-84d1-4fa2-8e01-3f5a8e33e9db__kdevelop-before.png
kdevelop-after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/beaeb568-f2f8-440c-a4e8-101e1e6c1499__kdevelop-after.png


Thanks,

Hugo Pereira Da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140822/5d43c612/attachment.html>