Review Request 119900: [OS X] less obtrusive missing declaration widget

RJVB Bertin rjvbertin at gmail.com
Fri Aug 22 12:06:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119900/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X and KDevelop.


Repository: kdevplatform


Description
-------

This patch renders the assistant popup widget used for suggesting to add missing declarations to a class being edited less obtrusive on configurations like OS X where the Alt modifier might be used in shortcuts like Word-Left/Right (to match them with the system default).

The patch basically makes the Alt keypress to handle the popup's programmatic shortcuts a transient trigger rather than a state change that persists until the popup is either accepted or dismissed.

For more details, see https://bugs.kde.org/show_bug.cgi?id=338380


Diffs
-----

  shell/assistantpopup.cpp 06d6ccf 

Diff: https://git.reviewboard.kde.org/r/119900/diff/


Testing
-------

With KDevelop 4.7RC (x.7.60) on OS X (10.6.8, KDE 4.12.5 and Qt 4.8.6 from MacPorts) and with KDevelop git/master on Linux (Ubuntu 14.04 with KDE 4.13.3 and Qt 4.8.6) with word left/right evoked by Alt+Left/Right).


Thanks,

RJVB Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140822/7f1dfe75/attachment.html>


More information about the KDevelop-devel mailing list