Review Request 119873: port unit tests to ecm_add_test cmake macro
Kevin Funk
kfunk at kde.org
Fri Aug 22 07:59:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119873/#review65009
-----------------------------------------------------------
Ship it!
Otherwise looks good.
language/codegen/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119873/#comment45445>
This and below:
Please use 4-char indentation levels.
- Kevin Funk
On Aug. 21, 2014, 6:53 p.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119873/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2014, 6:53 p.m.)
>
>
> Review request for KDevelop and Kevin Funk.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> simplify tests/CMakeLists.txt by using ecm_add_test macro
>
>
> Diffs
> -----
>
> CMakeLists.txt 520caca
> language/backgroundparser/tests/CMakeLists.txt 78f0625
> language/codegen/tests/CMakeLists.txt 3ab99ba
> language/duchain/tests/CMakeLists.txt 0bae0bd
> language/highlighting/tests/CMakeLists.txt 88f7c6f
> plugins/bazaar/tests/CMakeLists.txt 272284b
> plugins/git/tests/CMakeLists.txt 22a455e
> plugins/grepview/tests/CMakeLists.txt 3e18be5
> plugins/projectfilter/tests/CMakeLists.txt 2f9a02f
> plugins/quickopen/tests/CMakeLists.txt 905a0b4
> plugins/standardoutputview/tests/CMakeLists.txt fea2e17
> project/tests/CMakeLists.txt 51d7cae
> serialization/tests/CMakeLists.txt d715570
> shell/tests/CMakeLists.txt 0d58fef
> sublime/tests/CMakeLists.txt 6d4d54c
> util/tests/CMakeLists.txt 990ddfa
> vcs/dvcs/tests/CMakeLists.txt 34c68c8
> vcs/models/tests/CMakeLists.txt 6980347
>
> Diff: https://git.reviewboard.kde.org/r/119873/diff/
>
>
> Testing
> -------
>
> make && ctest
> some tests are failing possibly due to my setup.
>
>
> Thanks,
>
> Laurent Navet
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140822/c91c398e/attachment.html>
More information about the KDevelop-devel
mailing list