Review Request 119708: Try not to lose imports while reparsing.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119708/#review64789
-----------------------------------------------------------

Ship it!


I think this should go in (after the few nitpicks where resolved). I still hope we could maybe fix clang here instead of doing all this manually. But


duchain/clanghelpers.cpp
<https://git.reviewboard.kde.org/r/119708/#comment45308>

    please prefer the other iterators:
    
        for (auto it = imports->constBegin(); it != imports->constEnd(); ++it) {
            ...
        }
    
    but actually, here you don't need the key at all, so a plain foreach would work as well:
    
        foreach (auto import, *imports) {
            ....
        }



duchain/clangindex.cpp
<https://git.reviewboard.kde.org/r/119708/#comment45309>

    please add a comment mentioning the issue and why we can't skip the pch decls then


- Milian Wolff


On Aug. 16, 2014, 10:17 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119708/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 10:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Here is what happens:
> We are using CXTranslationUnit_PrecompiledPreamble flag, that makes clang internally use pch, but clang_getInclusions doesn't visit pch.
> 
> So let's try to extract this information manually
> 
> 
> Diffs
> -----
> 
>   duchain/clanghelpers.cpp 2c66421 
>   duchain/clangindex.cpp bd6c678 
>   tests/test_duchain.h 7844c17 
>   tests/test_duchain.cpp 563de7a 
> 
> Diff: https://git.reviewboard.kde.org/r/119708/diff/
> 
> 
> Testing
> -------
> 
> Added an unit test for it.
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140818/f07dc096/attachment-0001.html>